rustc_driver cleanup #83610
Merged
rustc_driver cleanup #83610
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorn3
added
C-cleanup
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Rebased and added two extra commits. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
ff2af40cd7d4d3373bfdc247f2ad8847213aea51 should be functionally identical. Can it be a spurious error? |
crlf0710
added
S-waiting-on-review
cjgillot
reviewed
May 2, 2021
This is one step towards separating the linking code from codegen backends
This allows removing a confusing mem::replace in create_global_ctxt
This comment has been minimized.
This comment has been minimized.
|
CI passed. |
|
@bors r+ |
|
📌 Commit 163b480 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
This was referenced May 12, 2021
|
Performance triage indicates that this PR introduced a 1.7% regression when fully compiling I don't think any performance hit was expected. However, it also seems like this may be just noise. |
bjorn3
commented
May 18, 2021
| @@ -967,7 +967,7 @@ pub struct GlobalCtxt<'tcx> { | |||
| export_map: ExportMap<LocalDefId>, | |||
|
|
|||
| pub(crate) untracked_crate: &'tcx hir::Crate<'tcx>, | |||
| pub(crate) definitions: &'tcx Definitions, | |||
| pub(crate) definitions: Definitions, | |||
There was a problem hiding this comment.
This is the only change I can think of that could caused the regression if it isn't just noise.
bjorn3
pushed a commit
to bjorn3/rust
that referenced
this pull request
May 27, 2021
rustc_driver cleanup Best reviewed one commit at a time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Best reviewed one commit at a time.